[PATCH] D37528: [JumpThreading] Preserve dominance across the pass.

[Brian Rzycki via Phabricator via llvm-commits]

brzycki added a comment.

In https://reviews.llvm.org/D37528#862800, @kuhar wrote:

>


One other comment: some of the layout of this patch was designed based on feedback between us in email. I asked you if applyUpdates() was more expensive for a single Insertion/Deletion than a direct call. Were I to assume otherwise some of the calls and logic would be simpler. I'd always create an Updates array and just push_back() throughout the function. On exit I'd call applyUpdates() with an empty vector or not. If you think code clarity trumps the (small?) performance deltas I'd be open to revisiting some of the call sites.


Repository:
  rL LLVM

https://reviews.llvm.org/D37528