[PATCH] D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API

[Alexander Benikowski via Phabricator via llvm-commits]

Memnarch added a comment.

In https://reviews.llvm.org/D35077#863412, @Wallbraker wrote:

> In https://reviews.llvm.org/D35077#863378, @Memnarch wrote:
>
> > In https://reviews.llvm.org/D35077#863339, @Wallbraker wrote:
> >
> > > I have updated the commit to use for locating the libs CMAKE_CFG_INTDIR and should fix the issue @Memnarch saw. I only have build tools installed so I don't know if I can test it under a Visual Studio like environment.
> > >
> > > Cheers, Jakob.
> >
> >
> > Can you check your diff? Expected changes in "tools/llvm-shlib/CMakeLists.txt" only but all files are modified with other changes(compare the new diff with the previous one)
>
>
> Those are not my changes, I think they are a artifact from me uploading a diff manually and the fact that the code has changed from the last time I uploaded the diff (The LLVM docs tells me to upload the diff with full context). There are two lines that show up in a slightly brighter green, those are the only changes I have made.


i suspected that. But for the purpose of this review, you should remove these changes


https://reviews.llvm.org/D35077