[PATCH] D29933: [RISCV 11/n] Initial codegen support for ALU operations

[Krzysztof Parzyszek via Phabricator via llvm-commits]

kparzysz added inline comments.


================
Comment at: lib/Target/RISCV/RISCVISelDAGToDAG.cpp:49
+  // If we have a custom node, we have already selected
+  if (Node->isMachineOpcode()) {
+    DEBUG(errs() << "== "; Node->dump(CurDAG); errs() << "\n");
----------------
asb wrote:
> kparzysz wrote:
> > I'm curious---do you expect Select to be called with a machine node?  Normally that should not happen.
> Select gets called when a node has been lowered using lowerExternalSymbol or lowerGlobalAddress. It's possible I'm missing a way to avoid this, though I can see that the x86 backend also has machine nodes reaching Select (verified by introducing an assert and running CodeGen/X86 tests). The same seems to be true of Hexagon.
You're right---Hexagon has that too, and it actually gets called with machine nodes.  Never mind, I guess... :)


https://reviews.llvm.org/D29933