[PATCH] D37563: Convenience/safety fix for llvm::sys::Execute(And|No)Wait

Alexander Kornienko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 7 05:03:12 PDT 2017


alexfh created this revision.

Change the type of the Redirects parameter of llvm::sys::ExecuteAndWait,
ExecuteNoWait and other APIs that wrap them from `const StringRef **` to
`ArrayRef<Optional<StringRef>>`, which is safer and simplifies the use of these
APIs (no more local StringRef variables just to get a pointer to).

Corresponding clang changes will be posted as a separate patch.


https://reviews.llvm.org/D37563

Files:
  include/llvm/Support/Program.h
  lib/Support/GraphWriter.cpp
  lib/Support/Program.cpp
  lib/Support/Signals.cpp
  lib/Support/Unix/Program.inc
  lib/Support/Windows/Program.inc
  tools/bugpoint/OptimizerDriver.cpp
  tools/bugpoint/ToolRunner.cpp
  tools/dsymutil/MachOUtils.cpp
  tools/llvm-cov/CodeCoverage.cpp
  unittests/Support/ProgramTest.cpp
  utils/not/not.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37563.114157.patch
Type: text/x-patch
Size: 17350 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170907/7154cf20/attachment.bin>


More information about the llvm-commits mailing list