[PATCH] D37393: [llvm-objcopy] Add support for special section indexes in symbol table greater than SHN_LORESERVE

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with the two minor changes I've suggested inline.



================
Comment at: test/tools/llvm-objcopy/section-index-unsupported.test:15
+
+# CHECK: [[_:.*]] Symbol 'test' has unsupported value greater than or equal to SHN_LORESERVE: 65285
----------------
I don't think you need the "[[_:.*]]". The check doesn't need to match the whole line.


================
Comment at: tools/llvm-objcopy/Object.cpp:110
+    return DefinedIn->Index;
+  } else {
+    switch (ShndxType) {
----------------
As the if returns, I think the LLVM style is to not have the "else" here - it just becomes the rest of the function.


Repository:
  rL LLVM

https://reviews.llvm.org/D37393