[PATCH] D29937: [RISCV 15/n] Implement lowering of ISD::SELECT_CC

[Mandeep Singh Grang via Phabricator via llvm-commits]

mgrang added inline comments.


================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:70
+// operation matches one of the comparisons supported directly in the RISC-V
+// ISA
+static void normaliseSetCC(SDValue &LHS, SDValue &RHS, ISD::CondCode &CC) {
----------------
Period at the end of comment.


================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:189
+  F->insert(I, TailMBB);
+  // Move all remaining instructions to TailMBB
+  TailMBB->splice(TailMBB->begin(), HeadMBB,
----------------
Ditto.


================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:195
+  TailMBB->transferSuccessorsAndUpdatePHIs(HeadMBB);
+  // Set the successors for HeadMBB
+  HeadMBB->addSuccessor(IfFalseMBB);
----------------
Ditto.


https://reviews.llvm.org/D29937