[PATCH] D23566: [RISCV 8/10] Add support for all RV32I instructions

[Mandeep Singh Grang via Phabricator via llvm-commits]

mgrang added inline comments.


================
Comment at: lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:146
+    char Prev = '\0';
+    for (char c : Str) {
+      if (c != 'i' && c != 'o' && c != 'r' && c != 'w')
----------------
Shouldn't this be:
```
for (char &c : Str)
```
Refer: https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable


================
Comment at: lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:266
+    unsigned Imm = 0;
+    for (char c : SE->getSymbol().getName()) {
+      switch (c) {
----------------
Ditto.


https://reviews.llvm.org/D23566