[PATCH] D35918: [GVNHoist] Factor out reachability to search for anticipable instructions quickly

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya marked an inline comment as done.
hiraditya added inline comments.


================
Comment at: lib/Transforms/Scalar/GVNHoist.cpp:117
 
-// A map from a pair of VNs to all the instructions with those VNs.
-typedef DenseMap<std::pair<unsigned, unsigned>, SmallVector<Instruction *, 4>>
-    VNtoInsns;
+typedef SmallVectorImpl<CHIArg>::iterator CHIIt;
+typedef DenseMap<BasicBlock *, SmallVector<CHIArg, 2>> OutValuesType;
----------------
dberlin wrote:
> All of the uses of this type should just be auto, AFAICT
CHHIt is used in function argument at a couple of places.


https://reviews.llvm.org/D35918