[PATCH] D37511: [dwarfdump] Verify line table prologue

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:455
+      } else {
+        llvm_unreachable("Invalid index?");
+      }
----------------
dblaikie wrote:
> Don't branch-to-unreachable. Use an assert instead.
> 
> Is the false return from getFileNameByIndex really impossible? (has the FileIndex been checked for validity? What other error paths does getFileNameByIndex have, if any?)
Thanks, an assert definitely better expresses the intent. The only path that returns false is this:
```
  if (Kind == FileLineInfoKind::None || !hasFileAtIndex(FileIndex))
    return false;
```
The `FileLineInfoKind` is hard-coded so that can't trigger it. The index can't really be invalid either as we're iterating over the list of indices. If this returns false here it must be a programmer error. 


Repository:
  rL LLVM

https://reviews.llvm.org/D37511