[PATCH] D36579: [ELF] - Do not fail when set versions for linkerscript's symbol aliases

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 6 04:12:12 PDT 2017


grimar added a comment.

In https://reviews.llvm.org/D36579#861514, @ruiu wrote:

> It doesn't feel right to add a new member to Symbol just for this. Can you add a DefinedRegular symbol with some dummy value instead of an Undefined symbol, no?


Yes, you right. In update (going to post in a minute) I used `addAbsolute` because it has less arguments than `addRegular` and used weak binding for these symbols to
avoid "duplicate symbol: _gp" error in ELF/mips-gp-ext.s. Linkersctipt's `addRegular` replaces binding with STB_GLOBAL for these symbols anyways.


https://reviews.llvm.org/D36579





More information about the llvm-commits mailing list