[PATCH] D37484: [libunwind] Always use unwind tables in tests

[Peter Smith via Phabricator via llvm-commits]

peter.smith updated this revision to Diff 113977.
peter.smith added a comment.

Yes you are correct, thanks for pointing that out. I had somewhat naively assumed the True and False was the test. I've updated the diff.


https://reviews.llvm.org/D37484

Files:
  test/libunwind/test/config.py


Index: test/libunwind/test/config.py
===================================================================
--- test/libunwind/test/config.py
+++ test/libunwind/test/config.py
@@ -43,10 +43,11 @@
 
     def configure_compile_flags(self):
         self.cxx.compile_flags += ['-DLIBUNWIND_NO_TIMER']
-        if self.get_lit_bool('enable_exceptions', True):
-            self.cxx.compile_flags += ['-funwind-tables']
-        else:
+        if not self.get_lit_bool('enable_exceptions', True):
             self.cxx.compile_flags += ['-fno-exceptions', '-DLIBUNWIND_HAS_NO_EXCEPTIONS']
+        # Stack unwinding tests need unwinding tables and these are not
+        # generated by default on all Targets.
+        self.cxx.compile_flags += ['-funwind-tables']
         if not self.get_lit_bool('enable_threads', True):
             self.cxx.compile_flags += ['-D_LIBUNWIND_HAS_NO_THREADS']
             self.config.available_features.add('libunwind-no-threads')


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37484.113977.patch
Type: text/x-patch
Size: 959 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170906/8085648e/attachment.bin>