[PATCH] D37463: Fix miscompile in LoopSink pass

Daniil Suchkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 6 03:11:26 PDT 2017


DaniilSuchkov abandoned this revision.
DaniilSuchkov added a comment.

Actually the answer is here: https://llvm.org/docs/Atomics.html#notatomic

> NotAtomic is the obvious, a load or store which is not atomic. (This isn’t really a level of atomicity, but is listed here for comparison.) This is essentially a regular load or store. 
>  ...
>  Notes for optimizers:
>  Introducing loads to shared variables along a codepath where they would not otherwise exist is allowed; introducing stores to shared variables is not.

So, this behavior of LoopSink is not a bug.


Repository:
  rL LLVM

https://reviews.llvm.org/D37463





More information about the llvm-commits mailing list