[PATCH] D37495: llvm-isel-fuzzer: Handle a subset of backend flags in the executable name

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added inline comments.


================
Comment at: lib/FuzzMutate/FuzzerCLI.cpp:61
+  for (std::string &S : Args)
+    CLArgs.push_back(S.c_str());
+
----------------
vsk wrote:
> We might be able to get a tighter test by printing out the args here, then checking for them in filecheck.
> 
> Pro: default behaviors (e.g gisel => -O0) become clearer.
> Con: This makes the fuzzer stdout a bit more crowded.
I would actually request that we print "Args" to errs() here, with some prefix, e.g.:
"Flags deducted from <BinaryName>: -foo -bar"

This way it will be trivial to test this and to manually verify the desired effect. 


Repository:
  rL LLVM

https://reviews.llvm.org/D37495