[PATCH] D37240: Fix crbug 759265 by suppressing llvm mt warnings.
Eric Beckmann via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 5 17:33:54 PDT 2017
ecbeckmann added inline comments.
================
Comment at: lld/COFF/DriverUtils.cpp:377
- return Merger.getMergedManifest();
+ return Merger.getMergedManifest().get()->getBuffer();
}
----------------
ruiu wrote:
> This is probably a sign that `getMergedManifest` should return a std::string instead of `std::unique_ptr<MemoryBuffer>`, but this doesn't have to be addressed in this patch.
ack
================
Comment at: lld/COFF/DriverUtils.cpp:406-407
+ return check(MemoryBuffer::getFile(User.Path), "could not open " + User.Path)
+ .get()
+ ->getBuffer();
}
----------------
ruiu wrote:
> Is this what clang-format formatted?
yes
https://reviews.llvm.org/D37240
More information about the llvm-commits
mailing list