[PATCH] D37240: Fix crbug 759265 by suppressing llvm mt warnings.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/COFF/DriverUtils.cpp:386-387
   if (!HostTriple.isOSWindows())
-    fatal("manifest ignored because no external manifest tool available");
+    fatal("external mt.exe is not available because this is not a Windows "
+          "system");
   // Create the default manifest file as a temporary file.
----------------
There are Windows systems that don't have mt.exe. :)


================
Comment at: lld/COFF/DriverUtils.cpp:422-424
+    OutputBuffer = createManifestXmlWithInternalMt(DefaultXml);
+  else
+    OutputBuffer = createManifestXmlWithExternalMt(DefaultXml);
----------------
It is more straightforward if you return a string from createManifestXmlWith{Internal,External}Mt.


https://reviews.llvm.org/D37240