[llvm] r312574 - [unittests] Add reverse iteration unit test for pointer-like keys

[Grang, Mandeep Singh via llvm-commits]

Thanks Davide for the fix!


On 9/5/2017 2:30 PM, Davide Italiano wrote:
> On Tue, Sep 5, 2017 at 1:57 PM, Davide Italiano <davide at freebsd.org> wrote:
>> On Tue, Sep 5, 2017 at 1:39 PM, Mandeep Singh Grang via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>>> Author: mgrang
>>> Date: Tue Sep  5 13:39:01 2017
>>> New Revision: 312574
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=312574&view=rev
>>> Log:
>>> [unittests] Add reverse iteration unit test for pointer-like keys
>>>
>> Unfortunately, this seems to have broken the build for me.
>>
>> [davide at ganondorf build-release]$ ninja check-llvm
>> [8/1733] Building CXX object
>> unittests/Support/CMakeFiles/SupportTests.dir/ReverseIterationTest.cpp.o
>> FAILED: /usr/lib64/ccache/c++   -DGTEST_HAS_RTTI=0 -D_DEBUG
>> -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
>> -D__STDC_LIMIT_MACROS -Iunittests/Support -I../unittests/Support
>> -I/usr/include/libxml2 -Iinclude -I../include
>> -I../utils/unittest/googletest/include
>> -I../utils/unittest/googlemock/include -fPIC
>> -fvisibility-inlines-hidden -Werror=date-time -std=c++11 -Wall -W
>> -Wno-unused-parameter -Wwrite-strings -Wcast-qual
>> -Wno-missing-field-initializers -pedantic -Wno-long-long
>> -Wno-maybe-uninitialized -Wdelete-non-virtual-dtor -Wno-comment
>> -ffunction-sections -fdata-sections -O3    -UNDEBUG
>> -Wno-variadic-macros -fno-exceptions -fno-rtti -MMD -MT
>> unittests/Support/CMakeFiles/SupportTests.dir/ReverseIterationTest.cpp.o
>> -MF unittests/Support/CMakeFiles/SupportTests.dir/ReverseIterationTest.cpp.o.d
>> -o unittests/Support/CMakeFiles/SupportTests.dir/ReverseIterationTest.cpp.o
>> -c ../unittests/Support/ReverseIterationTest.cpp
>> ../unittests/Support/ReverseIterationTest.cpp:60:19: error:
>> specialization of ‘template<class T> struct llvm::DenseMapInfo’ in
>> different namespace [-fpermissive]
>>   template<> struct DenseMapInfo<PtrLikeInt *> {
>>                     ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> In file included from ../include/llvm/ADT/DenseMap.h:17:0,
>>                   from ../unittests/Support/ReverseIterationTest.cpp:14:
>> ../include/llvm/ADT/DenseMapInfo.h:29:8: error:   from definition of
>> ‘template<class T> struct llvm::DenseMapInfo’ [-fpermissive]
>>   struct DenseMapInfo {
>>          ^~~~~~~~~~~~
> Went ahead and committed a fix as r312579.
>