[PATCH] D37393: [llvm-objcopy] Add support for special section indexes in symbol table greater than SHN_LORESERVE

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 5 14:58:27 PDT 2017


jakehehrlich updated this revision to Diff 113920.
jakehehrlich added a comment.

1. Fixed function name to be isValidReservedSectionIndex
2. Changed message to correctly indicate that it should be >= and not >
3. Switched to using an enum style solution. I added a method, getShndx that figures out what the correct value of st_shndx should be. I also switched how addSymbol works to account for this.


Repository:
  rL LLVM

https://reviews.llvm.org/D37393

Files:
  test/tools/llvm-objcopy/abs-symbol.test
  test/tools/llvm-objcopy/common-symbol.test
  test/tools/llvm-objcopy/section-index-unsupported.test
  tools/llvm-objcopy/Object.cpp
  tools/llvm-objcopy/Object.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37393.113920.patch
Type: text/x-patch
Size: 8868 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170905/bdcdb5b9/attachment.bin>


More information about the llvm-commits mailing list