[PATCH] D36745: [LLD][ELF] Always write non-immediate bits for AArch64 branch instruction.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Arch/AArch64.cpp:236
   case R_AARCH64_JUMP26:
+    // When patching instructions we may use a branch immediate to overwrite a
+    // potentially non-branch instruction so write the full branch instruction
----------------
Can you mention that this is for --fix-cortex-a53-843419, as what this code does is unusual and doesn't make much sense unless the reader understand this is for a CPU bug.


================
Comment at: ELF/Arch/AArch64.cpp:240
+    write32le(Loc, 0x14000000);
+    // Fallthrough
+  case R_AARCH64_CALL26:
----------------
Can you use LLVM_FALLTHROUGH intead?


https://reviews.llvm.org/D36745