[PATCH] D37240: Fix crbug 759265 by suppressing llvm mt warnings.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Looks like this is towards a right direction.



================
Comment at: lld/COFF/DriverUtils.cpp:427-432
+#if LLVM_WIN_MANIFEST_ENABLED
+      OutputBufferOrError = createManifestXmlWithInternalMt(DefaultXml);
+#else
+      // Shell out to mt.exe instead.
+      OutputBufferOrError = createManifestXmlWithExternalMt(DefaultXml);
+#endif
----------------
Since createmanifestXmlWith{Internal,External}Mt are lld-specific functions, I wouldn't make them return Expected<T>. I'd handle errors inside these functions and return T instead.

(As to the formatting, please do not indent code for C macros.)


https://reviews.llvm.org/D37240