[PATCH] D37483: AMDGPU: AMDPAL scratch buffer support

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 5 10:15:16 PDT 2017


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SIFrameLowering.cpp:359
 
-  if (ResourceRegUsed && (ST.isMesaGfxShader(MF) || (PreloadedPrivateBufferReg == AMDGPU::NoRegister))) {
+  if (ResourceRegUsed && ST.isAmdPalOS()) {
+    // The pointer to the GIT is formed from the offset passed in and either
----------------
arsenm wrote:
> This looks like it breaks mesa
Oh, I see that just moved. Can you maybe extract this + the mesa setup to a separate function?


https://reviews.llvm.org/D37483





More information about the llvm-commits mailing list