[PATCH] D37481: [DebugInfo] Verify that sibling and children fall in parent range.

[David Blaikie via llvm-commits]

Might be better to reduce some source code, produce assembly, then tweak
that slightly before going to yaml. Not sure.

On Tue, Sep 5, 2017 at 10:05 AM Jonas Devlieghere via Phabricator <
reviews at reviews.llvm.org> wrote:

> JDevlieghere added a comment.
>
> @dblaikie  wrote:
>
> > Might be worth looking at the previous review on this:
> https://reviews.llvm.org/D32821
> >
> > (yeah, it stalled out - partly my fault, I did go back to try to work up
> the changes I'd been suggesting, but hit some other issues that I gave up
> on - might be worth discussing design first a bit before diving into the
> code changes)
> >
> > I imagine a test for this could be reduced beyond 700 lines of YAML -
> happy to help with that if you get stuck/have trouble reducing/simplifying
> it.
> >
> > (I mean there's several things to test for here, but one basic one
> should be well reduced to ~10s of lines, hopefully)
>
>
> Thanks David, that looks very similar indeed! The truth is that I don't
> really have an idea how to get started on reducing a YAML test case without
> breaking everything. I've given it a try but the result wasn't valid
> anymore, even before changing the ranges.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D37481
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170905/bac191d2/attachment.html>