[PATCH] D37396: AMDGPU: Cleanup/refactor SIMemoryLegalizer [3]:

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl added inline comments.


================
Comment at: lib/Target/AMDGPU/SIMemoryLegalizer.cpp:195
   if (!MI->hasOneMemOperand())
-    return SIMemOpInfo();
+    return SIMemOpInfo(SyncScope::System,
+                       AtomicOrdering::SequentiallyConsistent);
----------------
t-tye wrote:
> Suggest comment along the lines:
> 
> 
> ```
> // Since machine memory operands are optional, if not present have to conservatively assume the worst case of a sequentially consistent system scope atomic.
> ```
> 
> Same comment for other factory methods.
Similar comment is in D37397.


https://reviews.llvm.org/D37396