[PATCH] D37460: [GVN] Prevent LoadPRE from hoisting through guards and assumes

[Daniel Berlin via Phabricator via llvm-commits]

dberlin requested changes to this revision.
dberlin added a comment.
This revision now requires changes to proceed.

1. This seems wrong for assumes (I don't know enough about guards).

It is not incorrect to hoist through an assume, nor should doing so generate wrong code.
Assumes are essentially metadata, and documented as such.

Can you provide an example where the code generated is incorrect?

(guards i don't know enough about to say anything).

2. You've done this in an N^2 way when it should be amortized constant time (using orderedinstructions)


https://reviews.llvm.org/D37460