[PATCH] D37471: [BasicTTIImpl] Remove Trunc and ZExt cost handling

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 5 05:57:56 PDT 2017


samparker created this revision.
Herald added a subscriber: javed.absar.

Since most transformations will be using TTI, which should then hold all the required information, just call the base getOperationCost without handling trunc and zext differently.


https://reviews.llvm.org/D37471

Files:
  include/llvm/CodeGen/BasicTTIImpl.h
  test/Transforms/SimplifyCFG/ARM/select-trunc-i64.ll


Index: test/Transforms/SimplifyCFG/ARM/select-trunc-i64.ll
===================================================================
--- /dev/null
+++ test/Transforms/SimplifyCFG/ARM/select-trunc-i64.ll
@@ -0,0 +1,25 @@
+; RUN: opt -S -simplifycfg -mtriple=arm < %s | FileCheck %s
+target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64"
+
+; CHECK-LABEL: select_trunc_i64
+; CHECK-NOT: br
+; CHECK: select
+; CHECK: select
+define arm_aapcscc i32 @select_trunc_i64(i32 %a, i32 %b) {
+entry:
+  %conv = sext i32 %a to i64
+  %conv1 = sext i32 %b to i64
+  %add = add nsw i64 %conv1, %conv
+  %cmp = icmp sgt i64 %add, 2147483647
+  br i1 %cmp, label %cond.end7, label %cond.false
+
+cond.false:                                       ; preds = %entry
+  %0 = icmp sgt i64 %add, -2147483648
+  %cond = select i1 %0, i64 %add, i64 -2147483648
+  %extract.t = trunc i64 %cond to i32
+  br label %cond.end7
+
+cond.end7:                                        ; preds = %cond.false, %entry
+  %cond8.off0 = phi i32 [ 2147483647, %entry ], [ %extract.t, %cond.false ]
+  ret i32 %cond8.off0
+}
Index: include/llvm/CodeGen/BasicTTIImpl.h
===================================================================
--- include/llvm/CodeGen/BasicTTIImpl.h
+++ include/llvm/CodeGen/BasicTTIImpl.h
@@ -265,21 +265,6 @@
   }
 
   unsigned getOperationCost(unsigned Opcode, Type *Ty, Type *OpTy) {
-    const TargetLoweringBase *TLI = getTLI();
-    switch (Opcode) {
-    default: break;
-    case Instruction::Trunc: {
-      if (TLI->isTruncateFree(OpTy, Ty))
-        return TargetTransformInfo::TCC_Free;
-      return TargetTransformInfo::TCC_Basic;
-    }
-    case Instruction::ZExt: {
-      if (TLI->isZExtFree(OpTy, Ty))
-        return TargetTransformInfo::TCC_Free;
-      return TargetTransformInfo::TCC_Basic;
-    }
-    }
-
     return BaseT::getOperationCost(Opcode, Ty, OpTy);
   }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37471.113844.patch
Type: text/x-patch
Size: 1890 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170905/401d3d00/attachment.bin>


More information about the llvm-commits mailing list