[PATCH] D37447: [Decompression] Fail gracefully when out of memory

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 5 03:03:39 PDT 2017


grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM, thanks ! (minor nit)



================
Comment at: lib/Object/Decompressor.cpp:98
+                                      bool) {
+  const auto *D = static_cast<class Decompressor *>(Data);
+  report_fatal_error("decompression of '" + Twine(D->SectionName) +
----------------
Did you mean 'const' instead of 'class' ?
Using of 'class' is inconsistend with LLVM code, I think it never uses it in
`static_cast` expressions, so I would remove it.


Repository:
  rL LLVM

https://reviews.llvm.org/D37447





More information about the llvm-commits mailing list