[PATCH] D36745: [LLD][ELF] Always write non-immediate bits for AArch64 branch instruction.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 5 01:28:48 PDT 2017

Previous message: [PATCH] D36745: [LLD][ELF] Always write non-immediate bits for AArch64 branch instruction.
Next message: [PATCH] D36745: [LLD][ELF] Always write non-immediate bits for AArch64 branch instruction.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

grimar added a comment.

Looks good, thanks ! I have no other comments (minor nit).



================
Comment at: test/ELF/relocation-b-aarch64.test:7
+
+# REQUIRES: aarch64
+
----------------
Please remove the duplicate, you have it at first line already.


https://reviews.llvm.org/D36745

Previous message: [PATCH] D36745: [LLD][ELF] Always write non-immediate bits for AArch64 branch instruction.
Next message: [PATCH] D36745: [LLD][ELF] Always write non-immediate bits for AArch64 branch instruction.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list