[PATCH] D37380: Triple: Add AMDPAL operating system type

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 4 12:45:59 PDT 2017

Previous message: [PATCH] D37274: [InstCombine] Remove foldSelectICmpAndOr. Instead call foldSelectICmpAnd as part of foldSelectIntoOp
Next message: [PATCH] D37380: Triple: Add AMDPAL operating system type
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

nhaehnle added a comment.

TripleTest.cpp has some minimally meaningful tests though. So a test of amdgcn-amd-amdpal should be added there. Apart from that the patch looks good.


https://reviews.llvm.org/D37380

Previous message: [PATCH] D37274: [InstCombine] Remove foldSelectICmpAndOr. Instead call foldSelectICmpAnd as part of foldSelectIntoOp
Next message: [PATCH] D37380: Triple: Add AMDPAL operating system type
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list