[PATCH] D36745: [LLD][ELF] Always write non-immediate bits for AArch64 branch instruction.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 4 07:33:50 PDT 2017
grimar added a comment.
In https://reviews.llvm.org/D36745#860283, @peter.smith wrote:
> Thanks both for the comments. My apologies for forgetting the context, I've added a new diff with it in. Adding a comprehensive test at this stage is difficult because (sensibly) there is no way with llvm-mc to generate a R_AARCH64_ JUMP26 relocation on a non branch instruction.
Thanks for test. I was not aware about such problem.
I think it should be possible to use yaml2obj to simplify it (up to you, just want to share the idea).
For example lld\test\ELF\relocation-none-aarch64.testis something very close to what I am thinking about,
it has single relocation and you probably should be able to replace it with R_AARCH64_JUMP26 and R_AARCH64_CALL26 relocations
to check which bytes LLD emits for them (and check that bytes are different after this patch).
https://reviews.llvm.org/D36745
More information about the llvm-commits
mailing list