[PATCH] D36742: [LLD][ELF][AArch64] Implement scanner for Cortex-A53 Erratum 843419

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/Driver.cpp:667
   Config->Pie = getArg(Args, OPT_pie, OPT_nopie, false);
+  Config->PrintFixes = Args.hasArg(OPT_print_fixes);
   Config->PrintGcSections = Args.hasArg(OPT_print_gc_sections);
----------------
Since this option is LLD specific, I wonder do we need it ? Can we just always report fixes
if -fix-cortex-a53-843419 is specified ?
Or may be always report them if -versbose is given.


================
Comment at: ELF/Writer.cpp:1326
   }
+  if (Config->EMachine == EM_AARCH64 && Config->FixCortexA53Errata843419) {
+    Script->assignAddresses();
----------------
Should we just fail in driver.cpp if -fix-cortex-a53-843419 used for non AARCH64 targets ?


https://reviews.llvm.org/D36742