[PATCH] D37364: [DWARF] Line 0 should not have a discriminator

Dehao Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 3 17:35:05 PDT 2017


danielcdh added a comment.

The change looks good to me. But the test is quite large and hard to understand. I don't think it's necessary to have the test generated from a source file, just forge a test with discriminator attached to line 0, and then checks if discriminators is omitted in the generated code. I guess it should suffice with < 20 LOC


https://reviews.llvm.org/D37364





More information about the llvm-commits mailing list