[polly] r312446 - [ForwardOpTree] Fix typos. NFC.

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 3 11:51:05 PDT 2017


I see. Thank you!

Best,
Tobias

On Sun, Sep 3, 2017, at 20:03, Tobias Grosser via llvm-commits wrote:
> 
> 
> On Sun, Sep 3, 2017, at 18:09, Michael Kruse via llvm-commits wrote:
> > Author: meinersbur
> > Date: Sun Sep  3 09:09:38 2017
> > New Revision: 312446
> > 
> > URL: http://llvm.org/viewvc/llvm-project?rev=312446&view=rev
> > Log:
> > [ForwardOpTree] Fix typos. NFC.
> > 
> > Modified:
> >     polly/trunk/lib/Transform/ForwardOpTree.cpp
> > 
> > Modified: polly/trunk/lib/Transform/ForwardOpTree.cpp
> > URL:
> > http://llvm.org/viewvc/llvm-project/polly/trunk/lib/Transform/ForwardOpTree.cpp?rev=312446&r1=312445&r2=312446&view=diff
> > ==============================================================================
> > --- polly/trunk/lib/Transform/ForwardOpTree.cpp (original)
> > +++ polly/trunk/lib/Transform/ForwardOpTree.cpp Sun Sep  3 09:09:38 2017
> > @@ -410,12 +410,12 @@ public:
> >      if (!LI)
> >        return FD_NotApplicable;
> >  
> > -    // If the load is already in the statement, not forwarding is
> > necessary.
> > +    // If the load is already in the statement, no forwarding is
> > necessary.
> >      // However, it might happen that the LoadInst is already present in
> >      the
> 
> should this read "is NOT YET present"?
> 
> >      // statement's instruction list. In that case we do as follows:
> >      // - For the evaluation (DoIt==false), we can trivially forward it
> >      as it is
> >      //   benefit of forwarding an already present instruction.
> > -    // - For the execution (DoIt==false), prepend the instruction (to
> > make it
> > +    // - For the execution (DoIt==true), prepend the instruction (to
> > make it
> >      //   available to all instructions following in the instruction
> >      list), but
> >      //   do not add another MemoryAccess.
> >      MemoryAccess *Access = TargetStmt->getArrayAccessOrNULLFor(LI);
> > 
> > 
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list