[PATCH] D37425: LoopVectorize: MaxVF should not be larger than the loop trip count

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 3 08:00:30 PDT 2017


hfinkel added inline comments.


================
Comment at: test/Transforms/LoopVectorize/X86/pr34438.ll:7
+; RUN: opt < %s -loop-vectorize -mtriple=x86_64-apple-macosx10.8.0 -mcpu=skylake-avx512 -debug-only=loop-vectorize -stats -S -vectorizer-min-trip-count=21 2>&1 | FileCheck %s
+; REQUIRES: asserts
+
----------------
Can you please test the output directly instead of testing the debug output? We generally test debug output when there's no other effective way to write a test. It's better to have non-asserts-requiring tests.



https://reviews.llvm.org/D37425





More information about the llvm-commits mailing list