[PATCH] D37388: [X86] Allow cross-lane permutations for sub targets supporting AVX2.

Guy Blank via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 3 04:22:58 PDT 2017


guyblank added a comment.

In https://reviews.llvm.org/D37388#859847, @jbhateja wrote:

> In https://reviews.llvm.org/D37388#859841, @guyblank wrote:
>
> > Hi Jatin,
> >  Thanks for working on this.
> >  You didn't add llvm-commits as a subscriber upon review creation, so this won't show up on the mailing list. Can you open a new review?
>
>
> Hi Guy,
>
> llvm-commits is already on subscriber's list for this differential revision. I did not not get your point in opeining a new review.
>
> Thanks


If you want the llvm-commits mailing list to be notified when you create a review, you need to add it as a subscriber when creating the review, not afterwards.
When you add it after the initial creation, there will be no mail notification to the list.
So in your case, the first message the list got was the 'ping'.
If llvm-commits was added upon creation, the first message would have been: 
jatin created this revision.
<the description of the revision>

Which I think is useful for people browsing the list.


https://reviews.llvm.org/D37388





More information about the llvm-commits mailing list