[PATCH] D37292: 'into' instruction should not be decoded as valid in 64-bit mode

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 1 22:09:35 PDT 2017


craig.topper added inline comments.


================
Comment at: lib/Target/X86/Disassembler/X86DisassemblerDecoder.cpp:761
     }
+  } else if (current == 0xce && (insn->mode == MODE_64BIT)) {
+    // TODO: Do we need real error diagnostic in disassembler?
----------------
We don't need to do this here. Just add Requires<[Not64BitMode]> to the end of the instruction definition in X86InstrSystem.td.


https://reviews.llvm.org/D37292





More information about the llvm-commits mailing list