[PATCH] D37389: [AMDGPU] Produce madak and madmk from the two-address pass
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 1 16:03:20 PDT 2017
rampitec added a comment.
In https://reviews.llvm.org/D37389#859399, @arsenm wrote:
> This looks like it is undoing the specific handling for 2 uses done in FoldImmediate. This also probably should be handled there, and specifically for 2 uses. Also needs a test with 3+ uses, where it probably still shouldn't be folded.
There is no point in the folding. Both mad and madak use 64 bit, both use constant bus. With folding we also using one extra register and plus madak/madmk are VOP2, so preferable.
https://reviews.llvm.org/D37389
More information about the llvm-commits
mailing list