[PATCH] D37396: AMDGPU: Cleanup/refactor SIMemoryLegalizer [3]:

[Tony Tye via Phabricator via llvm-commits]

t-tye accepted this revision.
t-tye added a comment.
This revision is now accepted and ready to land.

LGTM except for suggested added comments.



================
Comment at: lib/Target/AMDGPU/SIMemoryLegalizer.cpp:195
   if (!MI->hasOneMemOperand())
-    return SIMemOpInfo();
+    return SIMemOpInfo(SyncScope::System,
+                       AtomicOrdering::SequentiallyConsistent);
----------------
Suggest comment along the lines:


```
// Since machine memory operands are optional, if not present have to conservatively assume the worst case of a sequentially consistent system scope atomic.
```

Same comment for other factory methods.


https://reviews.llvm.org/D37396