[PATCH] D37321: llvm-mt: Fix memory management in WindowsManifestMergerImpl::getMergedManifest

[Eric Beckmann via Phabricator via llvm-commits]

ecbeckmann added a comment.

Sorry for being so late to respond to this, I've been busy with team match this week.

Thanks for catching these errors.  It was my fault for just using unique_ptr instead of explicitly calling xmlFree on the xmlDoc structures.  However, I'm confused about the XML_PARSE_NODICT flag, how will this help?  As far as I can tell it prevents the creation of a new string dictionary for that xmlDoc that is parsed?  Which could be a problem if I had href's and namespaces in one tree point to another.  However I never do this and always duplicate the entire string from one tree to another.

Also how did you discover the presence of memory problems?  I've looked on msan and nothing seems to be there.


https://reviews.llvm.org/D37321