[PATCH] D37175: Fix PR/33305. caused by trying to simplify expressions in phi of ops that should have no leaders.

[Davide Italiano via Phabricator via llvm-commits]

davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.

I gave a round of light testing to this during the morning and it didn't expose any significant issue. 
I agree with your plan, this looks like a good starting point. I'm not exactly looking forward to seeing fuzzer generated crazy miscompiles, so I hope this sticks together.



================
Comment at: include/llvm/ADT/PackedVector.h:60
       val = ~val;
-      Bits.set((Idx << (BitNum-1)) + BitNum-1);
+0      Bits.set((Idx << (BitNum-1)) + BitNum-1);
     }
----------------
This change slipped through the cracks.


================
Comment at: lib/Transforms/Scalar/NewGVN.cpp:1797
+      // in a different context.
+      if (!DT->dominates(PBranch->To, getBlockForValue(I)))
+        continue;
----------------
I thought this part already went in


https://reviews.llvm.org/D37175