[PATCH] D37351: AMDGPU: Add most d16 load/store instruction definitions

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 1 11:32:24 PDT 2017


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/FLATInstructions.td:1032
+defm SCRATCH_STORE_BYTE_D16_HI : FLAT_Real_AllAddr_vi <0x19>;
+defm SCRATCH_LOAD_UBYTE_D16 : FLAT_Real_AllAddr_vi <0x20>;
+defm SCRATCH_LOAD_UBYTE_D16_HI : FLAT_Real_AllAddr_vi <0x21>;
----------------
rampitec wrote:
> The last place ;)
The problem with these is the new instructions are longer, so it requires reformatting everything else around it (which is why I didn't want to have any of these aligned in the first place)


https://reviews.llvm.org/D37351





More information about the llvm-commits mailing list