[PATCH] D37351: AMDGPU: Add most d16 load/store instruction definitions

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/DSInstructions.td:468
+def DS_READ_U8_D16 : DS_1A_RET<"ds_read_u8_d16">;
+def DS_READ_U8_D16_HI : DS_1A_RET<"ds_read_u8_d16_hi">;
+def DS_READ_I8_D16 : DS_1A_RET<"ds_read_i8_d16">;
----------------
Here as well...


================
Comment at: lib/Target/AMDGPU/FLATInstructions.td:917
 def FLAT_STORE_SHORT_vi        : FLAT_Real_vi <0x1a, FLAT_STORE_SHORT>;
+def FLAT_STORE_SHORT_D16_HI_vi  : FLAT_Real_vi <0x1b, FLAT_STORE_SHORT_D16_HI>;
 def FLAT_STORE_DWORD_vi        : FLAT_Real_vi <0x1c, FLAT_STORE_DWORD>;
----------------
Here as well...


================
Comment at: lib/Target/AMDGPU/FLATInstructions.td:923
 
+def FLAT_LOAD_UBYTE_D16_vi : FLAT_Real_vi <0x20, FLAT_LOAD_UBYTE_D16>;
+def FLAT_LOAD_UBYTE_D16_HI_vi : FLAT_Real_vi <0x21, FLAT_LOAD_UBYTE_D16_HI>;
----------------
Here as well...


================
Comment at: lib/Target/AMDGPU/FLATInstructions.td:978
 
+defm GLOBAL_LOAD_UBYTE_D16 : FLAT_Real_AllAddr_vi <0x20>;
+defm GLOBAL_LOAD_UBYTE_D16_HI : FLAT_Real_AllAddr_vi <0x21>;
----------------
Here as well...


================
Comment at: lib/Target/AMDGPU/FLATInstructions.td:1031
 defm SCRATCH_STORE_BYTE : FLAT_Real_AllAddr_vi <0x18>;
+defm SCRATCH_STORE_BYTE_D16_HI : FLAT_Real_AllAddr_vi <0x19>;
+defm SCRATCH_LOAD_UBYTE_D16 : FLAT_Real_AllAddr_vi <0x20>;
----------------
Here as well...


https://reviews.llvm.org/D37351