[PATCH] D36813: [Coverage] Build sorted and unique segments

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

In https://reviews.llvm.org/D36813#858542, @ikudrin wrote:

> Yes, if it's possible, I'd like to see all the patches (one way or another), just to have the whole picture.


Understood, https://reviews.llvm.org/D37387 is the only extra patch needed.

> I don't insist on dividing the patch if you find it impractical. Do I understand it right that you've added all the found edge cases as unit tests in `ProfileData/CoverageMappingTest.cpp`?

Thanks, I do find it a bit impractical. I've added all the edge cases I found as separate unit tests. I've also completed a stage2 coverage-enabled run with an asserts-enabled clang/llvm-cov, and checked that the segment builder changes are fully covered.


https://reviews.llvm.org/D36813