[PATCH] D37372: [XRay][compiler-rt] Make __xray_CustomEvent PIC friendlier and build a dynamic version of the XRay runtime

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

I'm not sure if this change will do what you think it does. The linker should create GOTs and PLTs for all symbols, even those defined by `.s` files, as long as an appropriate relocation exists. In particular the change you are making in https://reviews.llvm.org/D37373 should on its own result in the creation of PLT entries for `__xray_CustomEntry`. Can you please explain the problem that you are trying to solve?


https://reviews.llvm.org/D37372