[PATCH] D37373: [XRay][CodeGen] Use PIC-friendly code in XRay sleds and remove synthetic references in .text
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 1 09:18:17 PDT 2017
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: test/CodeGen/X86/xray-custom-log.ll:15
; CHECK-NEXT: movq {{.*}}, %rsi
- ; CHECK-NEXT: movabsq $__xray_CustomEvent, %rax
- ; CHECK-NEXT: callq *%rax
- ; CHECK-NEXT: popq %rax
+ ; CHECK-NEXT: callq __xray_CustomEvent
+ ; CHECK-NEXT: popq %rsi
----------------
Add another `RUN` line above with `-relocation-model=pic` so you can test for `@PLT` here.
https://reviews.llvm.org/D37373
More information about the llvm-commits
mailing list