[PATCH] D37163: [LICM] sink through non-trivially replicable PHI

[Jun Bum Lim via Phabricator via llvm-commits]

junbuml added a comment.

Of course, it would be good to avoid unnecessary splitting in the fist place if it's not very costly. 
Let me try to find reasonable an approach for this.

> The case where you can't place it somewhere safe should be the case where the edge is critical.
> Otherwise, there should always be somewhere to place the computation safely and correctly.

I'm not perfectly clear about your above comment. Did you mean that we cannot safely sink a sinkable instruction through a critical edge? In such case we should split the critical edge to sink?


https://reviews.llvm.org/D37163