[PATCH] D37269: Add support for custom loaders to the sanitizer symbolizer

Francis Ricci via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 1 07:49:26 PDT 2017


fjricci added a comment.

`modules_.enableFallbackInit()` will only return `true` once (if use_fallback_init_ is already enabled, it returns `false`), so there shouldn't be an infinite recursion anywhere.

The issue that this is trying to solve is that the Linux `LoadedModules` uses `dl_iterate_phdr` by default. This is an api function of the system loader, so it works fine for libraries loaded by the system loader, but won't find any libraries not loaded by the system loader. If you use a custom loader (for example, Faulty.lib) to load some of your libraries, they won't appear in `dl_iterate_phdr`, because the system loader didn't load them. They are still loaded in the memory map though, so they will appear in procmaps.


https://reviews.llvm.org/D37269





More information about the llvm-commits mailing list