[PATCH] D37377: [ARM] Add 2-operand assembly aliases for Thumb1 ADD/SUB

Evgeny Astigeevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 1 05:56:06 PDT 2017


eastig added a comment.

In https://reviews.llvm.org/D37377#858689, @rengolin wrote:

> As I said in https://reviews.llvm.org/D37374, please refrain from approving your own patches within minutes of posting. The community must be part of the process, and if people are not reviewing your patches as fast as you want, then there's either something wrong with the community (and we need to fix), or with your expectations.
>
> If the problem is in the community, then the documented approach to make people care about your work is to care about theirs first. The more you review other people's patches, the more likely they are to review yours. If that doesn't work (after months), then we should discuss the problems in the dev list.


Hi Renato,

I agree with you: other people from the community should also have a chance to review patches.

There might be my fault because I put my comment with the action 'Accept revision'. My understanding of the use of 'Accept revision' is that I have reviewed a patch and I accept it. Further steps, especially when to commit, should be done according to the LLVM developer policy. Maybe my understanding of this is wrong.

Sorry for the inconvenience caused.
-Evgeny


Repository:
  rL LLVM

https://reviews.llvm.org/D37377





More information about the llvm-commits mailing list