[PATCH] D37370: ModuleSummaryAnalysis: Correctly handle refs from function inline asm to module inline asm.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 31 22:34:51 PDT 2017


mehdi_amini added inline comments.


================
Comment at: llvm/test/Bitcode/thinlto-asm-noimport.ll:2
+; RUN: opt -module-summary -o %t %s
+; RUN: llvm-bcanalyzer -dump %t | FileCheck %s
+
----------------
Is llvm-bcanalyzer *still* our only / preferred way of testing? :(


================
Comment at: llvm/test/Bitcode/thinlto-asm-noimport.ll:5
+target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64"
+target triple = "thumbv7--linux-android"
+
----------------
I suspect this test is target dependent (requires the backend compiled in to parse the inline asm) and so couldn't be in the generic bitcode test.


https://reviews.llvm.org/D37370





More information about the llvm-commits mailing list