[PATCH] D37351: AMDGPU: Add most d16 load/store instruction definitions

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/BUFInstructions.td:1593
 
+defm BUFFER_LOAD_UBYTE_D16 : MUBUF_Real_AllAddr_vi <0x20>;
+defm BUFFER_LOAD_UBYTE_D16_HI : MUBUF_Real_AllAddr_vi <0x21>;
----------------
Do you mind to align this block as around?


================
Comment at: lib/Target/AMDGPU/DSInstructions.td:467
+let SubtargetPredicate = HasD16LoadStore in {
+def DS_READ_U8_D16 : DS_1A_RET<"ds_read_u8_d16">;
+def DS_READ_U8_D16_HI : DS_1A_RET<"ds_read_u8_d16_hi">;
----------------
And also align here and below.


https://reviews.llvm.org/D37351