[PATCH] D36628: [test-suite]: Adding Lulesh Proxy-app

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

This fails verification for me on macOS:

  $ diff -u /Users/mbraun/dev/test-suite/build/MultiSource/Benchmarks/DOE-ProxyApps-C++/lulesh/Output/lulesh2.0.test.out /Users/mbraun/dev/test-suite/MultiSource/Benchmarks/DOE-ProxyApps-C++/lulesh/lulesh2.0.reference_output
  --- /Users/mbraun/dev/test-suite/build/MultiSource/Benchmarks/DOE-ProxyApps-C++/lulesh/Output/lulesh2.0.test.out	2017-08-31 19:08:44.000000000 -0700
  +++ /Users/mbraun/dev/test-suite/MultiSource/Benchmarks/DOE-ProxyApps-C++/lulesh/lulesh2.0.reference_output	2017-08-31 19:05:32.000000000 -0700
  @@ -16,8 +16,8 @@
      Iteration count     =  231
      Final Origin Energy = 2.720531e+04
      Testing Plane 0 of Energy Array on rank 0:
  -        MaxAbsDiff   = 4.774847e-12
  -        TotalAbsDiff = 2.590793e-11
  -        MaxRelDiff   = 1.443890e-13
  +        MaxAbsDiff   = 2.273737e-12
  +        TotalAbsDiff = 1.659646e-11
  +        MaxRelDiff   = 4.649603e-14
  
   exit 0



================
Comment at: MultiSource/Benchmarks/DOE-ProxyApps-C++/lulesh/CMakeLists.txt:1
+set(PROG lulesh2.0)
+list(APPEND LDFLAGS -g -O3)
----------------
Could we name the binary the same as the directory?


================
Comment at: MultiSource/Benchmarks/DOE-ProxyApps-C++/lulesh/CMakeLists.txt:2-3
+set(PROG lulesh2.0)
+list(APPEND LDFLAGS -g -O3)
+list(APPEND CXXFLAGS -g -O3 -I. -Wall -DUSE_MPI=0 -D_OPENMP=0)
+set(RUN_OPTIONS -s 10 -b 1)
----------------
Please don't specify `-O3, -g` optimization and debug flags should be specified for the llvm-testsuite as a whole and people do not expect them to be overridden by benchmarks.


================
Comment at: MultiSource/Benchmarks/DOE-ProxyApps-C++/lulesh/Makefile:4-5
+PROG = lulesh2.0
+LDFLAGS = -g -O3
+CXXFLAGS = -g -O3 -I. -Wall -DUSE_MPI=0 -D_OPENMP=0
+RUN_OPTIONS = -s 10 -b 1
----------------
see above.


https://reviews.llvm.org/D36628