[PATCH] D37215: [ValueTracking] improve reverse assumption inference

[Ariel Ben-Yehuda via llvm-commits]

Are not all the `isAssumeLikeIntrinsic` intrinsics are argmemonly?

On Thu, Aug 31, 2017 at 5:41 PM, Hal Finkel via Phabricator
<reviews at reviews.llvm.org> wrote:
> hfinkel added a comment.
>
> This looks good, however, you need to either:
>
> 1. Don't remove isAssumeLikeIntrinsic, but instead, update isGuaranteedToTransferExecutionToSuccessor to call it.
> 2. Update isGuaranteedToTransferExecutionToSuccessor to have the complete list from isAssumeLikeIntrinsic.
>
> Right now, isGuaranteedToTransferExecutionToSuccessor only checks:
>
>   return CS.onlyReadsMemory() || CS.onlyAccessesArgMemory() ||
>          match(I, m_Intrinsic<Intrinsic::assume>());
>
>
> https://reviews.llvm.org/D37215
>
>
>